Messages in this thread | | | Date | Mon, 10 Oct 2005 17:22:02 -0500 | From | David Teigland <> | Subject | Re: [PATCH 11/16] GFS: mount and tuning options |
| |
On Mon, Oct 10, 2005 at 10:30:26PM +0100, Al Viro wrote: > On Mon, Oct 10, 2005 at 02:19:18PM -0700, Greg KH wrote: > > > > > + rv += sprintf(buf + rv, "bsize %u\n", sdp->sd_sb.sb_bsize); > > > > > + rv += sprintf(buf + rv, "total %lld\n", sc.sc_total); > > > > > + rv += sprintf(buf + rv, "free %lld\n", sc.sc_free); > > > > > + rv += sprintf(buf + rv, "dinodes %lld\n", sc.sc_dinodes); > > > > > > > > No, 1 value per sysfs file please. > > > > > > I'm aware of that rule and have followed it everywhere else. This is a > > > special case where the one statfs produces three results. > > > > Then why not have 4 different files, for the result of the last "statfs" > > command? > > More to the point, what the hell is that doing in sysfs in the first place?
It gave extended, gfs-specific usage information not available through df. It's not valuable enough to keep around for the confusion and questions it's raised so I've removed it.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |