lkml.org 
[lkml]   [2005]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 167] Kill unused variables in the net code
    On Fri, 7 Jan 2005, linux-os wrote:
    > On Fri, 7 Jan 2005, Geert Uytterhoeven wrote:
    > > 2.4.28-rc2 introduced a warning in the net code on non-SMP:
    > >
    > > net/core/neighbour.c:1809: warning: unused variable `tbl'
    > >
    > > The following patch fixes this.
    > >
    > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    > >
    > > --- linux-2.4.29-rc1/include/linux/spinlock.h 2004-04-27 17:22:10.000000000
    > > +0200
    > > +++ linux-m68k-2.4.29-rc1/include/linux/spinlock.h 2005-01-07
    > > 21:51:28.000000000 +0100
    > > @@ -147,7 +147,7 @@
    > >
    > > #define rwlock_init(lock) do { } while(0)
    > > #define read_lock(lock) (void)(lock) /* Not "unused variable". */
    > > -#define read_unlock(lock) do { } while(0)
    > > +#define read_unlock(lock) (void)(lock) /* Not "unused variable". */
    > > #define write_lock(lock) (void)(lock) /* Not "unused variable". */
    > > #define write_unlock(lock) do { } while(0)
    > But don't all you need to do is:
    >
    > #define read_unlock(x)

    No, since the `x' may refer to a variable that's further unused (cfr.
    net/core/neighbour.c:1809).

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.019 / U:1.500 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site