lkml.org 
[lkml]   [2005]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] properly split capset_check+capset_set
    * Alan Cox (alan@lxorguk.ukuu.org.uk) wrote:
    > On Maw, 2005-01-04 at 16:27, Serge E. Hallyn wrote:
    > > The attached patch removes checks from kernel/capability.c which are
    > > redundant with cap_capset_check() code, and moves the capset_check()
    > > calls to immediately before the capset_set() calls. This allows
    > > capset_check() to accurately check the setter's permission to set caps
    > > on the target. Please apply.
    >
    > Why does this help ?

    Without this change, the check was done without knowing who the target
    really was, so the code that sets it had to check as well.

    > A partial failure now returns no error ?

    It never did. Now it behaves the same as signal delivery which returns
    success if any signals were delivered, and failure if none were delivered.

    thanks,
    -chris
    --
    Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.042 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site