lkml.org 
[lkml]   [2005]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: page fault scalability patch V14 [5/7]: x86_64 atomic pte operations
    On Tue, 4 Jan 2005, Brian Gerst wrote:

    > > +#define pud_test_and_populate(mm, pud, pmd) \
    > > + (cmpxchg((int *)pgd, PUD_NONE, _PAGE_TABLE | __pa(pmd)) == PUD_NONE)
    > ^^^
    > Shouldn't this be pud?

    Corrrect. Sigh. Could someone test this on x86_64?

    Index: linux-2.6.10/include/asm-x86_64/pgalloc.h
    ===================================================================
    --- linux-2.6.10.orig/include/asm-x86_64/pgalloc.h 2005-01-03 15:02:01.000000000 -0800
    +++ linux-2.6.10/include/asm-x86_64/pgalloc.h 2005-01-04 12:31:14.000000000 -0800
    @@ -7,6 +7,10 @@
    #include <linux/threads.h>
    #include <linux/mm.h>

    +#define PMD_NONE 0
    +#define PUD_NONE 0
    +#define PGD_NONE 0
    +
    #define pmd_populate_kernel(mm, pmd, pte) \
    set_pmd(pmd, __pmd(_PAGE_TABLE | __pa(pte)))
    #define pud_populate(mm, pud, pmd) \
    @@ -14,11 +18,24 @@
    #define pgd_populate(mm, pgd, pud) \
    set_pgd(pgd, __pgd(_PAGE_TABLE | __pa(pud)))

    +#define pmd_test_and_populate(mm, pmd, pte) \
    + (cmpxchg(pmd, PMD_NONE, _PAGE_TABLE | __pa(pte)) == PMD_NONE)
    +#define pud_test_and_populate(mm, pud, pmd) \
    + (cmpxchg(pud, PUD_NONE, _PAGE_TABLE | __pa(pmd)) == PUD_NONE)
    +#define pgd_test_and_populate(mm, pgd, pud) \
    + (cmpxchg(pgd, PGD_NONE, _PAGE_TABLE | __pa(pud)) == PGD_NONE)
    +
    +
    static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, struct page *pte)
    {
    set_pmd(pmd, __pmd(_PAGE_TABLE | (page_to_pfn(pte) << PAGE_SHIFT)));
    }

    +static inline int pmd_test_and_populate(struct mm_struct *mm, pmd_t *pmd, struct page *pte)
    +{
    + return cmpxchg(pmd, PMD_NONE, _PAGE_TABLE | (page_to_pfn(pte) << PAGE_SHIFT)) == PMD_NONE;
    +}
    +
    extern __inline__ pmd_t *get_pmd(void)
    {
    return (pmd_t *)get_zeroed_page(GFP_KERNEL);
    Index: linux-2.6.10/include/asm-x86_64/pgtable.h
    ===================================================================
    --- linux-2.6.10.orig/include/asm-x86_64/pgtable.h 2005-01-03 15:02:01.000000000 -0800
    +++ linux-2.6.10/include/asm-x86_64/pgtable.h 2005-01-04 12:29:25.000000000 -0800
    @@ -413,6 +413,10 @@
    #define kc_offset_to_vaddr(o) \
    (((o) & (1UL << (__VIRTUAL_MASK_SHIFT-1))) ? ((o) | (~__VIRTUAL_MASK)) : (o))

    +
    +#define ptep_cmpxchg(__vma,__addr,__xp,__oldval,__newval) (cmpxchg(&(__xp)->pte, pte_val(__oldval), pte_val(__newval)) == pte_val(__oldval))
    +#define __HAVE_ARCH_ATOMIC_TABLE_OPS
    +
    #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG
    #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_DIRTY
    #define __HAVE_ARCH_PTEP_GET_AND_CLEAR
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.022 / U:61.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site