lkml.org 
[lkml]   [2005]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] relayfs redux, part 2
    On Mon, Jan 31, 2005 at 05:10:27PM -0500, Karim Yaghmour wrote:
    >
    > Greg KH wrote:
    > > On Fri, Jan 28, 2005 at 01:38:22PM -0600, Tom Zanussi wrote:
    > >
    > >>+extern void * alloc_rchan_buf(unsigned long size,
    > >>+ struct page ***page_array,
    > >>+ int *page_count);
    > >>+extern void free_rchan_buf(void *buf,
    > >>+ struct page **page_array,
    > >>+ int page_count);
    > >
    > >
    > > As these will be "polluting" the global namespace of the kernel, could
    > > you add "relayfs_" to the front of them?
    >
    > BTW, these functions are in buffers.h which is an internal header to
    > fs/relayfs/*.c files. buffers.h is not included in anything outside.
    > Correct me if I'm wrong, but there is no namespace pollution in that
    > case, right? All that does contribute to namespace pollution is in
    > include/linux/relayfs_fs.h.

    When relayfs is built into the kernel, those symbols are then global to
    the whole static kernel.

    Please be nice and rename them.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:5.023 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site