Messages in this thread | | | Date | Mon, 31 Jan 2005 10:21:48 -0800 | From | Greg KH <> | Subject | Re: [PATCH 2.6] I2C: New chip driver: sis5595 |
| |
On Tue, Jan 25, 2005 at 11:09:45PM +0100, Aur?lien Jarno wrote: > +/* Locate SiS bridge and correct base address for SIS5595 */ > +static int sis5595_find_sis(int *address) > +{ > + u16 val; > + int *i; > + > + if (!(s_bridge = > + pci_find_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))
Please use pci_get_device(). It's safer, and not a depreciated function.
> + /* Look for imposters */ > + for(i = blacklist; *i != 0; i++) { > + if (pci_find_device(PCI_VENDOR_ID_SI, *i, NULL)) {
Same here.
> + printk("sis5595.ko: Error: Looked for SIS5595 but found unsupported device %.4X\n", *i);
<snip>
> + printk("sis5595.ko: base address not set - upgrade BIOS or use force_addr=0xaddr\n");
These printk() calls need a KERN_ level. Why not use the dev_* calls instead? You have a pci_dev to use here, right?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |