Messages in this thread | | | Date | Sat, 29 Jan 2005 15:25:37 -0800 | From | Greg KH <> | Subject | Re: [PATCH 2.6.11-rc2] I2C: lm80 driver improvement - |
| |
On Thu, Jan 27, 2005 at 11:56:46AM -0500, Shawn Starr wrote: > Description: Cleanup some cluttered macros, add error > checking for fan divisor value set.
Hm, we'll get there yet. Your patch was not in a plain text form, so that I could apply it directly from the email.
> Approved-by: Greg KH <greg@kroah.com>
I have not "approved it" yet at all.
> Signed-off-by: Sytse Wielinga > <s.b.wielinga@student.utwente.nl> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Shawn Starr <shawn.starr@rogers.com>
You have line wrap here too :(
> --- Greg KH <greg@kroah.com> wrote: > > On Wed, Jan 26, 2005 at 12:31:30PM -0500, Shawn > > Starr wrote: > > > Here is the corrected fix, yeah that didn't make > > > sense. > > > 3AM isn't a good time to send patches I guess :-) > > > > Care to resend it, with a full description and a > > Signed-off-by: line so > > I can apply it? > > > > thanks, > > > > greg k-h > >
What's this "bottom post" stuff in here?
Also, please CC: the sensors mailing list so the developers there can review the changes.
Can you try it again from scratch?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |