Messages in this thread | | | Date | Sat, 29 Jan 2005 21:36:42 +0000 | From | John Levon <> | Subject | Re: [PATCH] OProfile: Fix oops on undetected CPU type |
| |
On Sat, Jan 29, 2005 at 09:47:42AM -0700, Zwane Mwaikambo wrote:
> > Unfortunately bkcvs seems out of date so I can't even look at this > > myself. > > Yes you are right, i checked bk and there was a lot of shuffling about due > to the timer override. But it looks like we're depending on the timer > variable being set. We could always just run timer_init if cpu_type is not > set. > > Signed-off-by: Zwane Mwaikambo <zwane@arm.linux.org.uk> > > ===== drivers/oprofile/oprof.c 1.11 vs edited ===== > --- 1.11/drivers/oprofile/oprof.c 2005-01-04 19:48:23 -07:00 > +++ edited/drivers/oprofile/oprof.c 2005-01-29 09:38:24 -07:00 > @@ -157,7 +157,7 @@ static int __init oprofile_init(void) > > oprofile_arch_init(&oprofile_ops); > > - if (timer) { > + if (timer || !oprofile_ops.cpu_type) {
Looks like you're still on the broken bkcvs, which is missing this patch:
http://linus.bkbits.net:8080/linux-2.5/cset@1.1966.1.72?nav=index.html|ChangeSet@-2w
which AFAICS is the correct solution to the problem.
regards, john - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |