lkml.org 
[lkml]   [2005]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RFC: use datacs is smc91x driver
On Tue, 25 Jan 2005, Ian Campbell wrote:

> On Tue, 2005-01-25 at 11:14 +0000, Ian Campbell wrote:
> > Are you happy with "iocs", "attrib" and "datacs" for the names?
>
> Of the platforms with an smc91x platform_device (according to grep) only
> 2 (lubbock, neponset) out of the 18 have memory resources other than the
> iocs (full list of platforms is at the end, after the patch)
>
> So for the sake of the least intrusive patch I think for the main iocs
> I'll call _byname and fallback on mem resource number 0 if no named iocs
> resource exists. attrib and datacs must be explicitly named. This allows
> most of the board ports to remain unchanged.

Sensible.

> I also noticed that the name propagates into /proc/iomem etc
> # cat /proc/iomem
> [...]
> 10000000-10000003 : datacs
> 10000000-10000003 : smc91x
> so perhaps smc91x-datacs -attrib -iocs might be more appropriate names?

Probably, although "iocs" is rather criptic for someone not familiar
with the chip. What about "smc91x-regs", "smc91x-attrib" and
"smc91x-data32" ?


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [from the cache]
©2003-2011 Jasper Spaans