lkml.org 
[lkml]   [2005]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] BUG in io_destroy (fs/aio.c:1248)

Anything wrong with just a get_ioctx() instead ?


--- aio.c 2005-01-12 09:30:44.000000000 +0530
+++ aio.c.fix 2005-01-25 08:51:31.000000000 +0530
@@ -1284,7 +1284,7 @@
ret = put_user(ioctx->user_id, ctxp);
if (!ret)
return 0;
-
+ get_ioctx(ioctx); /* as io_destroy() expects us to hold a ref */
io_destroy(ioctx);
}


On Mon, Jan 24, 2005 at 04:43:21PM -0800, Darrick J. Wong wrote:
> Andrew Morton wrote:
>
> > So... Will someone be sending a new patch?
>
> Here's a cheesy patch that simply marks the ioctx as dead before
> destroying it. Though I'd like to simply mark the ioctx as dead until
> it actually gets used, I don't know enough about the code to make that
> sort of invasive change.
>
> --D
>
> -----------------
> Signed-off-by: Darrick Wong <djwong@us.ibm.com>
>
> --- linux-2.6.10/fs/aio.c.old 2005-01-24 16:12:46.000000000 -0800
> +++ linux-2.6.10/fs/aio.c 2005-01-24 16:30:53.000000000 -0800
> @@ -1285,6 +1285,10 @@
> if (!ret)
> return 0;
>
> + spin_lock_irq(&ctx->ctx_lock);
> + ctx->dead = 1;
> + spin_unlock_irq(&ctx->ctx_lock);
> +
> io_destroy(ioctx);
> }
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-aio' in
> the body to majordomo@kvack.org. For more info on Linux AIO,
> see: http://www.kvack.org/aio/
> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.054 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site