Messages in this thread | | | Subject | Re: [RFC][PATCH] new timeofday arch specific timesources (v. A2) | From | john stultz <> | Date | Mon, 24 Jan 2005 16:04:48 -0800 |
| |
On Mon, 2005-01-24 at 15:29 -0800, Christoph Lameter wrote: > On Mon, 24 Jan 2005, john stultz wrote: > > > +/* helper macro to atomically read both cyclone counter registers */ > > +#define read_cyclone_counter(low,high) \ > > + do{ \ > > + high = cyclone_timer[1]; low = cyclone_timer[0]; \ > > + } while (high != cyclone_timer[1]); > > This is only necessary on 32 bit platforms. On ia64 an atomic read would > do the job. Maybe that logic needs to go into the custom defined readq for > 32 bit? Then you could avoid repeating the code for drivers that read 64 > bit clocks on 32bit processors.
Yea, I still need to convert the cyclone timesource to an TIMESOURCE_MMIO_64. Hopefully I'll get to that in the next release.
thanks again for the review and feedback! -john
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |