Messages in this thread | | | Subject | Re: [Fastboot] [PATCH] Reserving backup region for kexec based crashdumps. | From | (Eric W. Biederman) | Date | 21 Jan 2005 00:54:06 -0700 |
| |
Vivek Goyal <vgoyal@in.ibm.com> writes:
> Hi Andrew, > > Following patch is against 2.6.11-rc1-mm2. > > As mentioned by following note from Eric, crashdump code is currently > broken. > > > > The crashdump code is currently slightly broken. I have attempted to > > minimize the breakage so things can quick be made to work again. > > We have started doing changes to make crashdump up and running again. > Following are few identified items to be done. > > 1. Reserve the backup region (640k) during kernel bootup.
Why do we need a separate region for this?
It should be simple enough to take 640 out of the area kexec reserves for the crash dump kernel. That is what the previous code implemented.
> 2. Copy the data to backup region during crash.(moved to kexec user > space code, patch posted in separate mail)
Thanks by and large it looks sane, it won't work yet the but it is moving in the right direction.
> +++ linux-2.6.11-rc1-mm2-kexec-eric-root/include/linux/kexec.h 2005-01-20 > 13:55:33.000000000 +0530 > > @@ -79,7 +79,7 @@ struct kimage { > unsigned long control_page; > > /* Flags to indicate special processing */ > - int type : 1; > + unsigned int type : 1;
That looks like a sane bug fix. Having values of 0 and -1 is quite what I was expecting...
Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |