lkml.org 
[lkml]   [2005]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 2.4.29] i810_audio: offset LVI from CIV to avoid stalled start
From
On Fri, Jan 21, 2005 at 09:07:13AM +1100, herbert wrote:
> On Thu, Jan 20, 2005 at 05:01:21PM -0500, John W. Linville wrote:
> > On Thu, Jan 20, 2005 at 04:23:46PM -0500, John W. Linville wrote:
> >
> > > + /* if we are currently stopped, then our CIV is actually set to our
> > > + * *last* sg segment and we are ready to wrap to the next. However,
> > > + * if we set our LVI to the last sg segment, then it won't wrap to
> > > + * the next sg segment, it won't even get a start. So, instead, when
> > > + * we are stopped, we increment the CIV value to the next sg segment
> > > + * to be played so that when we call start, things will operate
> > > + * properly
> > > + */
> >
> > Is this (slightly altered) comment more to your liking? If so,
> > I'll post an additive patch for the 2.6 version...
>
> IMHO the last sentence is still wrong. We're not touching the value
> of CIV at all. We're setting LVI to CIV + 1...
>
> OTOH, perhaps we should actually try implementing what the comment
> suggests?

OK I dug into the archives and found that the reason we need to do
it this way is because you can't set the value of CIV directly. So
how about s/CIV/LVI/ in the last sentence?

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.068 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site