Messages in this thread Patch in this message | | | Date | Wed, 19 Jan 2005 10:22:45 -0800 | From | Steve Longerbeam <> | Subject | Re: BUG in shared_policy_replace() ? |
| |
Andi Kleen wrote:
>>got it, except that there is no "new2 = NULL;" in 2.6.10-mm2! >> >>Looks like it was misplaced, because I do see it now in 2.6.10. >> >> > >I double checked 2.6.10 and the code also looks correct me, >working as described by Hugh. > >Optimistic locking can be ugly :) > >
yeah, 2.6.10 makes sense to me too. But I'm working in -mm2, and the new2 = NULL line is missing, hence my initial confusion. Trivial patch to -mm2 attached. Just want to make sure it has been, or will be, put back in.
Steve --- mm/mempolicy.c.orig 2005-01-19 09:52:47.153910873 -0800 +++ mm/mempolicy.c 2005-01-19 09:53:21.548999628 -0800 @@ -1041,6 +1041,7 @@ } n->end = start; sp_insert(sp, new2); + new2 = NULL; break; } else n->end = start;
| |