Messages in this thread | | | Date | 18 Jan 2005 12:01:28 +0100 | Date | Tue, 18 Jan 2005 12:01:28 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 2/5] socket ioctl fix (from Andi) |
| |
> > - if (cmd >= SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE + 15)) { > > + if (S_ISSOCK(filp->f_dentry->d_inode->i_mode) && > > + cmd >= SIOCDEVPRIVATE && cmd <= (SIOCDEVPRIVATE + 15)) { > > error = siocdevprivate_ioctl(fd, cmd, arg); > > Maybe this should move into a new sock_compat_ioctl() instead? >
Seems like overkill for 3 lines of code.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |