Messages in this thread | | | Date | Tue, 18 Jan 2005 14:47:37 -0800 | From | Chris Wright <> | Subject | Re: [PATCH 1/1] tpm: fix cause of SMP stack traces |
| |
* Kylene Hall (kjhall@us.ibm.com) wrote: > I actually had to move the location of some of the locks to remove the > might sleep warnings.
Ah, that sounds like the proper fix.
> Since I didn't know much about the might sleep > warnings before, my first course of action was to try using the disable > irq mechanism and I went ahead and just left them in once it was working > with the new lock placements. I assume you believe they shouldn't be > necessary at all?
Right. Unless you're taking same spin_lock in irq context (which I didn't recall you were doing).
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |