lkml.org 
[lkml]   [2005]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/13] remove cli()/sti() in drivers/char/*
    From
    Date
    On Sul, 2005-01-16 at 21:04, Andrew Morton wrote:
    > James Nelson <james4765@cwazy.co.uk> wrote:
    > >
    > > This series of patches removes the last cli()/sti()/save_flags()/restore_flags()
    > > function calls in drivers/char.
    >
    > I don't see much point in this, really. Those cli() calls are a big fat
    > sign saying "broken on smp" and they now generate compile-time warnings
    > emphasising that. These drivers still need to be fixed up - we may las
    > well leave them as-is until someone gets onto doing that.

    Please drop all the serial ones. I'm slowly working through the serial
    drivers that are relevant to any kind of users and fixing them up or
    importing fixes from vendor branches as appropriate.

    Simple substitions don't work here, and in some cases even simple tty
    device locks because many cards are chip level interfaces not port
    level.

    Alan

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean