Messages in this thread | | | Subject | Re: [PATCH 1/1] pci: Block config access during BIST (resend) | From | Alan Cox <> | Date | Thu, 13 Jan 2005 15:35:59 +0000 |
| |
On Maw, 2005-01-11 at 17:33, Andi Kleen wrote: > > User space does not expect to get dumped with -EBUSY randomly on PCI > > I think it's a reasonable thing to do. If you prefer you could fake a > 0xffffffff read, that would look like busy or non existing hardware. > But the errno would seem to be cleaner to me.
Either will break X.
> > static int pci_user_wait_access(struct pci_dev *pdev) { > > wait_event(&pci_ucfg_wait, dev->block_ucfg_access == 0); > > } > > I don't like this very much. What happens when the device > doesn't get out of BIST for some reason?
Then you need to switch to wait_event_timeout(). Its not terribly hard 8)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |