Messages in this thread | | | Subject | Re: [PATCH] release_pcibus_dev() crash | From | John Rose <> | Date | Thu, 13 Jan 2005 11:49:11 -0600 |
| |
> Maybe, did you read Documentation/filesystems/sysfs-pci.c? You need to do > more than just enable HAVE_PCI_LEGACY, you also need to implement some > functions.
This sounds like more than I bargained for. I'll leave the patch as-is, since I don't currently have the means to test a fix for the legacy IO stuff. Also because it doesn't crash on my architecture :)
If you get some time, my suggestion is to scrap pci_remove_legacy_files(), and free the pci_bus->legacy_io field in pci_remove_bus(). The binary sysfs files will be cleaned up automatically as the class device is deleted, as described in the parent.
Thanks- John
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |