lkml.org 
[lkml]   [2005]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[patch 03/11] arch/i386/pci/i386.c: Use new for_each_pci_dev macro
    From
    Date



    As requested by Christoph Hellwig I've created a new macro called
    for_each_pci_dev. It is a wrapper for this common use of pci_get/find_device:

    (while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL))

    This macro will return the pci_dev *for all pci devices. Here is the first patch I
    used to test this macro with. Compiled and booted on my T23. There will be
    53 more patches using this new macro.

    Hanna Linder
    IBM Linux Technology Center

    Signed-off-by: Hanna Linder <hannal@us.ibm.com>
    Signed-off-by: Maximilian Attems <janitor@sternwelten.at>

    ---

    Signed-off-by: Domen Puncer <domen@coderock.org>
    ---


    kj-domen/arch/i386/pci/i386.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff -puN arch/i386/pci/i386.c~for-each-pci-dev-arch_i386_pci_i386 arch/i386/pci/i386.c
    --- kj/arch/i386/pci/i386.c~for-each-pci-dev-arch_i386_pci_i386 2005-01-10 17:59:57.000000000 +0100
    +++ kj-domen/arch/i386/pci/i386.c 2005-01-10 17:59:57.000000000 +0100
    @@ -124,7 +124,7 @@ static void __init pcibios_allocate_reso
    u16 command;
    struct resource *r, *pr;

    - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
    + for_each_pci_dev(dev) {
    pci_read_config_word(dev, PCI_COMMAND, &command);
    for(idx = 0; idx < 6; idx++) {
    r = &dev->resource[idx];
    @@ -168,7 +168,7 @@ static int __init pcibios_assign_resourc
    int idx;
    struct resource *r;

    - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
    + for_each_pci_dev(dev) {
    int class = dev->class >> 8;

    /* Don't touch classless devices and host bridges */
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.024 / U:121.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site