Messages in this thread | | | Date | Tue, 11 Jan 2005 14:44:47 -0800 | From | Greg KH <> | Subject | Re: [PATCH] PCI patches for 2.6.10 |
| |
On Tue, Jan 11, 2005 at 02:39:02PM -0800, Matt Mackall wrote: > On Mon, Jan 10, 2005 at 09:20:55AM -0800, Greg KH wrote: > > ChangeSet 1.1938.439.44, 2005/01/07 10:32:39-08:00, domen@coderock.org > > > > [PATCH] hotplug/acpiphp_ibm: module_param fix > > > > File permissins should be octal number. > > > -module_param(debug, bool, 644); > > +module_param(debug, bool, 0644); > > Perhaps the sysfs code could do: > > /* did we forget to write in octal? */ > BUG_ON(mode > 0666 || mode & 0111);
I think the whole tree has now been audited. Mistakes from now on are the developer who did the change's fault (like all other kernel bugs...)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |