Messages in this thread | | | Date | Tue, 11 Jan 2005 11:55:41 -0800 (PST) | From | Steve G <> | Subject | Re: [PATCH] Trusted Path Execution LSM 0.2 (20050108) |
| |
This patch leaks memory in the error paths. For example:
+static ssize_t trustedlistadd_read_file(struct tpe_list *list, char *buf) +{ <snip> + char *buffer = kmalloc(400, GFP_KERNEL); + + user = (char *)__get_free_page(GFP_KERNEL); + if (!user) + return -ENOMEM;
There's several of these.
-Steve Grubb
__________________________________ Do you Yahoo!? The all-new My Yahoo! - What will yours do? http://my.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |