Messages in this thread | | | Date | Mon, 10 Jan 2005 19:00:52 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH] /driver/net/wan/sbs520 |
| |
Adam Anthony <AAnthony@sbs.com> : [...] > It would be great to receive some feedback on our work, and we hope > that this driver will eventually be added to the kernel.
It will probably require a few extra steps: - read Documentation/CodingStyle (mixed case, typedef from hell, ugly #ifdef); - grep ^static -> no static functions ? Uh ? - use non-obsolete API (pci_find_device in 2005 ?); - convert the os independant wrappers.
Btw it would probably make sense 1) to figure out what can be merged with the in-tree DSCC4 driver and 2) to integrate the driver with the existing hdlc stack. Imho there is some duplicated work/code.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |