Messages in this thread | | | Subject | Re: [PATCH] missing pci_disable_device() | From | Alan Cox <> | Date | Thu, 09 Sep 2004 14:11:13 +0100 |
| |
On Iau, 2004-09-09 at 11:29, Kenji Kaneshige wrote: > > dev_warn(&pci_dev->dev, "Device was removed without properly " > > "calling pci_disable_device(), please fix.\n"); > > WARN_ON(1); > >
"This may need fixing" would be better than "please fix" as it may be a wrong warning
> I changed my patch based on your feedback. But I have one > concern about putting "WARN_ON(1);". I'm worrying that people > might be surprised if stack dump is shown on their console, > especially if the broken driver handles many devices.
You could put
#ifdef CONFIG_DEBUG_KERNEL
#endif
around that section, then only users selecting kernel debugging would be bothered by it.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |