lkml.org 
[lkml]   [2004]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [ACPI] Re: [PATCH] Oops and panic while unloading holder of pm_idle
Hello Shaohua,

> + /* Wait the idle thread to read the new value,
> + * otherwise we Oops.
> + */

I should have mentioned this earlier, but the comment needs work,
something like this;

"We are about to unload the current idle thread pm callback (pm_idle),
Wait for all processors to update cached/local copies of pm_idle before
proceeding."

> + /* If pm_idle is in a module and is preempted,
> + * oops occurs. Disable preempt.
> + */

"Mark this as an RCU critical section so that synchronize_kernel() in the
unload path waits for our completion."

Then resend the patch, i swear it'll be the last time ;)

Thanks,
Zwane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.048 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site