lkml.org 
[lkml]   [2004]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [ACPI] Re: [PATCH] Oops and panic while unloading holder of pm_idle
Hello Shaohua,

On Wed, 8 Sep 2004, Li, Shaohua wrote:

> Yes, preempt will cause oops in pc_idle. Attached patch should close the
> final race corner.

Please try and inline your patches in future, i know it may be hard with
your mail client but it makes commenting on patches easier.

while (!need_resched()) {
+ void (*idle)(void) = NULL;
+

You don't need to initialise variable `idle` here. Otherwise the rest
looks fine with me.

Thanks,
Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.051 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site