Messages in this thread | | | Date | Wed, 8 Sep 2004 16:03:23 +0200 | From | Olaf Hering <> | Subject | Re: [PATCH] CONFIG_CMDLINE broken on ppc |
| |
On Wed, Sep 08, Tom Rini wrote:
> On Wed, Sep 08, 2004 at 03:40:28PM +0200, Olaf Hering wrote: > > > CONFIG_CMDLINE can not work on ppc. > > machine_init() copies the string to cmd_line, then platform_init() is > > called. It truncates the string to length zero. > > This has come up before, actually. What happens if CMDLINE isn't set, > and we don't terminate cmd_line here? It's part of the BSS and is > zero'd out anyways?
strlcpy generates a null-terminated string, if size != 0. Looks like that line can go. Or move it at the start of machine_init().
-- USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |