lkml.org 
[lkml]   [2004]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: netpoll trapped question
On Tue, Aug 31, 2004 at 01:10:43PM -0400, Jeff Moyer wrote:
> Hi, Matt,
>
> This part of the netpoll trapped logic seems suspect to me, from
> include/linux/netdevice.h:
>
> static inline void netif_wake_queue(struct net_device *dev)
> {
> #ifdef CONFIG_NETPOLL_TRAP
> if (netpoll_trap())
> return;
> #endif
> if (test_and_clear_bit(__LINK_STATE_XOFF, &dev->state))
> __netif_schedule(dev);
> }
>
> static inline void netif_stop_queue(struct net_device *dev)
> {
> #ifdef CONFIG_NETPOLL_TRAP
> if (netpoll_trap())
> return;
> #endif
> set_bit(__LINK_STATE_XOFF, &dev->state);
> }
>
> This looks buggy. Network drivers are now not able to stop the queue when
> they run out of Tx descriptors. I think the __netif_schedule is okay to do
> in the context of netpoll, and certainly a set_bit is okay. Why are these
> hooks in place? I've tested alt-sysrq-t over netconsole and also netdump
> with these #ifdef's removed, and things work correctly. Compare this with
> alt-sysrq-t hanging the system with these tests in place. If I run netdump
> with this logic still in place, I get the following messages from the tg3
> driver:
>
> eth0: BUG! Tx Ring full when queue awake!
>
> Shall I send a patch, or have I missed something?

I don't remember the origin or motivation of this bit, so I'm not sure
at the moment. Shoot me a patch and I'll poke at it.

Btw, did I send you my thoughts on your recursion patch?

--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.074 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site