Messages in this thread Patch in this message | | | From | Bernhard Rosenkraenzer <> | Subject | [PATCH] 2.6.9-rc1-mm3 i8042 compilation | Date | Fri, 3 Sep 2004 09:43:10 +0200 |
| |
On Friday 03 September 2004 10:48, Andrew Morton wrote: > +acpi-based-i8042-keyboard-aux-controller-enumeration.patch
This one is broken:
drivers/input/serio/i8042.c: In function `acpi_i8042_kbd_add': drivers/input/serio/i8042.c:1133: error: `i8042_data_reg' undeclared (first usein this function) drivers/input/serio/i8042.c:1133: error: (Each undeclared identifier is reported only once drivers/input/serio/i8042.c:1133: error: for each function it appears in.) drivers/input/serio/i8042.c:1134: error: `i8042_command_reg' undeclared (first use in this function) drivers/input/serio/i8042.c:1135: error: `i8042_status_reg' undeclared (first use in this function)
Looks like it's assigning values to variables that are neither declared nor used anywhere - so the fix is fairly easy (attached).
LLaP bero --- linux-2.6.8/drivers/input/serio/i8042.c.ark 2004-09-03 09:40:56.000000000 +0200 +++ linux-2.6.8/drivers/input/serio/i8042.c 2004-09-03 09:41:12.000000000 +0200 @@ -1130,9 +1130,6 @@ acpi_device_name(device), acpi_device_bid(device), i8042.port1, i8042.port2, i8042.irq); - i8042_data_reg = i8042.port1; - i8042_command_reg = i8042.port2; - i8042_status_reg = i8042.port2; i8042_kbd_values.irq = i8042.irq; return 0; | |