lkml.org 
[lkml]   [2004]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: PATCH: fix the barrier IDE detection logic
    On Fri, Sep 03 2004, Bartlomiej Zolnierkiewicz wrote:
    >
    > On Tuesday 31 August 2004 18:50, Alan Cox wrote:
    > > This fixes the logic so we always check for the cache. It also defaults
    > > to safer behaviour for the non cache flush case now we have the right bits
    > > in the right places. I've also played a bit with timings - the worst case
    > > timings I can get for the flush are about 7 seconds (which I'd expect
    > > as the engineering worst cases will include retries)
    > >
    > > Probably what should happen is that the barrier logic is enabled providing
    > > the wcache is disabled. I've not meddled with this as I don't know what
    > > the intended semantics and rules are for disabling barrier on a live disk
    > > (eg when a user uses hdparm to turn on the write cache). In the current
    > > code as with Jens original that cannot occur.
    >
    > I think that logic is reversed here, I guess it should be: enable barrier
    > if user enables wcache and disable it if user disables wcache.

    There's no need for changes, ide_queue_flush_cmd() handles this fine
    right now.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.021 / U:0.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site