Messages in this thread | | | Date | Sun, 26 Sep 2004 07:41:52 -0700 | From | "Martin J. Bligh" <> | Subject | Re: ptep_establish/establish_pte needs set_pte_atomic and all set_pte must be written in asm |
| |
>> anyways on x86 the bug is real in practice, regardless of the C >> compiler, heck we even put a smp_wmb() in between the two writes. The >> fact all other archs are buggy in theory too is just a corollary. I >> thought it worth to fix the theoretical bug in all other archs too, >> instead of keeping playing russian roulette. > > How so ? A bunch of archs have the pte beeing a simple long, on these > set_pte is perfectly atomic as it is... I'd say in this regard that > x86 is the exception ;)
Wouldn't it make sense to call set_pte_atomic, and just have that resolve to set_pte on 90% of arches? (I'm ignoring the wierdo compiler issue here, this is just for arches with pte > long).
M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |