lkml.org 
[lkml]   [2004]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add hook for PCI resource deallocation
On Fri, Sep 24, 2004 at 01:02:52PM -0700, Ashok Raj wrote:
> On Thu, Sep 16, 2004 at 05:54:14AM -0700, Kenji Kaneshige wrote:
> >
> > Hi,
> >
> > This patch adds a hook 'pcibios_disable_device()' into
> > pci_disable_device() to call architecture specific PCI resource
> > deallocation code. It's a opposite part of pcibios_enable_device().
> > We need this hook to deallocate architecture specific PCI resource
> > such as IRQ resource, etc.. This patch is just for adding the hook,
> > so pcibios_disable_device() is defined as a null function on all
> > architecture so far.
> >
> > I tested this patch on i386, x86_64 and ia64. But it has not been
> > tested on other architectures because I don't have these machines.
> >
> > Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> >
>
> Hi Kenji
>
> I think instead of modifying all the arch specific code, you could use the __attribute__(weak)
> and define a default dummy funcion in drivers/pci/pci.c
>
> void __attribute__((weak)) pcibios_disable_device(struct pci_dev *dev) { }
>
>
> each arch that really needs this can define the override function.
> That way you dont need to put the dummy function in several places,
> containing your changes to a very few set of files.

Ohhh, nice. I like that option better. Kenji, care to respin your
patches based on this change?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [from the cache]
©2003-2011 Jasper Spaans