Messages in this thread | | | Subject | Re: 2.6.9-rc2-mm3 | From | Paul Fulghum <> | Date | Fri, 24 Sep 2004 15:40:15 -0500 |
| |
On Fri, 2004-09-24 at 14:43, Russell King wrote: > a port supporting only 8 bit data transmission > must not report in termios that it is set to 7 bit data transmission.
OK, the check should stay.
Side note: the current check has an off by one bug:
if (cbaud < 1 || cbaud + 15 > n_baud_table) termios->c_flag &= ~CBAUDEX; else cbaud += 15;
where cbaud is an index into baud_table array and n_baud_table is the number of elements in baud_table. The conditional should be:
if (cbaud < 1 || cbaud + 15 >= n_baud_table)
-- Paul Fulghum paulkf@microgate.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |