lkml.org 
[lkml]   [2004]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.9-rc2-mm3
From
Date
On Fri, 2004-09-24 at 14:43, Russell King wrote:
> a port supporting only 8 bit data transmission
> must not report in termios that it is set to 7 bit data transmission.

OK, the check should stay.

Side note: the current check has an off by one bug:

if (cbaud < 1 || cbaud + 15 > n_baud_table)
termios->c_flag &= ~CBAUDEX;
else
cbaud += 15;

where cbaud is an index into baud_table array
and n_baud_table is the number of elements
in baud_table. The conditional should be:

if (cbaud < 1 || cbaud + 15 >= n_baud_table)


--
Paul Fulghum
paulkf@microgate.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.040 / U:2.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site