lkml.org 
[lkml]   [2004]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [ACPI] PATCH-ACPI based CPU hotplug[4/6]-Dynamic cpu register/unregister support
    On Mon, 20 Sep 2004 09:41:07 -0700 Keshavamurthy Anil S wrote:
    > ---
    > Name:topology.patch
    > Status:Tested on 2.6.9-rc2
    > Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
    > Depends:
    > Version: applies on 2.6.9-rc2
    > Description:
    > Extends support for dynamic registration and unregistration of the cpu,
    > by implementing and exporting arch_register_cpu()/arch_unregister_cpu().
    > Also combines multiple implementation of topology_init() functions to
    > single topology_init() in case of ia64 architecture.
    > ---

    > +void arch_unregister_cpu(int num)
    > +{
    > + struct node *parent = NULL;
    > +
    > +#ifdef CONFIG_NUMA
    > + int node = cpu_to_node(num);
    > + if (node_online(node))
    > + parent = &sysfs_nodes[node];
    > +#endif /* CONFIG_NUMA */
    > +
    > + return unregister_cpu(&sysfs_cpus[num].cpu, parent);
    > +}

    I don't think that the check 'if (node_online(node))' is necessary
    because sysfs_nodes[node] is there no matter if the node is online
    or offline. sysfs_nodes[] is cleared only when unregister_node()
    is called and it would be always called after unregister_cpu().

    Thanks,
    Keiichiro Tokunaga


    Name: arch_register_cpu_fix.patch
    Status: Tested on 2.6.9-rc2
    Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>

    ---

    linux-2.6.9-rc2-fix-kei/arch/ia64/kernel/topology.c | 3 +--
    1 files changed, 1 insertion(+), 2 deletions(-)

    diff -puN arch/ia64/kernel/topology.c~arch_register_cpu_fix arch/ia64/kernel/topology.c
    --- linux-2.6.9-rc2-fix/arch/ia64/kernel/topology.c~arch_register_cpu_fix 2004-09-22 11:56:58.793274256 +0900
    +++ linux-2.6.9-rc2-fix-kei/arch/ia64/kernel/topology.c 2004-09-22 11:56:58.795227390 +0900
    @@ -46,8 +46,7 @@ void arch_unregister_cpu(int num)

    #ifdef CONFIG_NUMA
    int node = cpu_to_node(num);
    - if (node_online(node))
    - parent = &sysfs_nodes[node];
    + parent = &sysfs_nodes[node];
    #endif /* CONFIG_NUMA */

    return unregister_cpu(&sysfs_cpus[num].cpu, parent);
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.024 / U:29.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site