Messages in this thread | | | Date | Thu, 2 Sep 2004 15:36:30 -0700 | From | Andrew Morton <> | Subject | Re: [patch 11/14] radio/radio-zoltrix: replace sleep_delay() with schedule() |
| |
janitor@sternwelten.at wrote: > > diff -puN drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix drivers/media/radio/radio-zoltrix.c > --- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix 2004-09-01 19:35:14.000000000 +0200 > +++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-zoltrix.c 2004-09-01 19:35:14.000000000 +0200 > @@ -54,12 +54,6 @@ struct zol_device { > > /* local things */ > > -static void sleep_delay(void) > -{ > - /* Sleep nicely for +/- 10 mS */ > - schedule(); > -} > - > static int zol_setvol(struct zol_device *dev, int vol) > { > dev->curvol = vol; > @@ -76,7 +70,7 @@ static int zol_setvol(struct zol_device > } > > outb(dev->curvol-1, io); > - sleep_delay(); > + schedule();
I'm inclined to leave this one as-is. If this driver really wants to sleep to 10ms then it should do so, rather than doing that pointless schedule(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |