lkml.org 
[lkml]   [2004]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 11/14] radio/radio-zoltrix: replace sleep_delay() with schedule()
janitor@sternwelten.at wrote:
>
> diff -puN drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix drivers/media/radio/radio-zoltrix.c
> --- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-zoltrix.c~msleep-drivers_media_radio-zoltrix 2004-09-01 19:35:14.000000000 +0200
> +++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-zoltrix.c 2004-09-01 19:35:14.000000000 +0200
> @@ -54,12 +54,6 @@ struct zol_device {
>
> /* local things */
>
> -static void sleep_delay(void)
> -{
> - /* Sleep nicely for +/- 10 mS */
> - schedule();
> -}
> -
> static int zol_setvol(struct zol_device *dev, int vol)
> {
> dev->curvol = vol;
> @@ -76,7 +70,7 @@ static int zol_setvol(struct zol_device
> }
>
> outb(dev->curvol-1, io);
> - sleep_delay();
> + schedule();

I'm inclined to leave this one as-is. If this driver really wants
to sleep to 10ms then it should do so, rather than doing that
pointless schedule().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.039 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site