Messages in this thread | | | Date | Thu, 2 Sep 2004 11:20:14 -0700 | From | William Lee Irwin III <> | Subject | Re: [PATCH] fixed pidhashing patch |
| |
On Thu, Sep 02, 2004 at 03:32:22PM +0400, Kirill Korotaev wrote: > I cleanuped it once again. It compiles/works fine. > Hope there will be no more problems with it. > list of small changes: > - FIXED bug in do_each_task_pid() made by Lee. last task was skipped in the loop, removed __list__ var. > - remade patch against latest tree (there was a conflict in exit.c) > - returned 'extern' in find_pid() declaration > - fixed style a bit in detach_pid(), find_task_by_pid_type()
Heh, looks like I flubbed the loop condition too. For some reason I thought pid_list was headed at the leader instead of being headerless, which upon a rereading I see now, so explaining my confusion there. The semicolon-requiring bits don't appear to be used by any of the other do { ... } while(...) -style iterators, so I won't press that.
This patch appears sound and stylistically good. Linus, please add:
Signed-off-by: William Irwin <wli@holomorphy.com>
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |