Messages in this thread | | | Date | Fri, 17 Sep 2004 19:34:08 -0400 | From | Jeff Garzik <> | Subject | Re: hotplug e1000 failed after 32 times |
| |
All this work and code for such an uncommon case??
First off, any settings which are _indexed_ are almost guaranteed broken. For reasons as we see here, and others. Any "setting_foo[board_number]" should be found and eliminated instead.
Even if you allocate and free board numbers as described, how precisely do you propose to predict which settings belong to which hotplugged board? Look at the problem, and you realize that the board<->setting association becomes effectively _random_ for any adapter not present at modprobe time.
The best model is to set these settings via netlink/ethtool after registering the interface, but before bringing it up.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |