lkml.org 
[lkml]   [2004]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PATCH: tty drivers take two
From
Date
Alan:

The N_TTY ldisc global reference leak
is still in tty_io.c release_dev().

This does not currently cause a problem because
N_TTY is never deregistered. It seems
a little ugly to have the N_TTY reference
invalid when all other ldisc references
are maintained. I could see this subtle
difference biting someone in the future
when working with this.

The lines that cause the leak serve no
purpose. There is no reason to assign
N_TTY ldisc to a tty instance that
is then immediately thrown away. The lines
that drop the reference to the current ldisc
are, of course, still needed.

--
Paul Fulghum
paulkf@microgate.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.057 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site