lkml.org 
[lkml]   [2004]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: 2.6.9-rc2-mm1
    Date
    On Thursday 16 September 2004 11:14 am, Jesse Barnes wrote:
    > On Thursday, September 16, 2004 2:40 am, Andrew Morton wrote:
    > > bk-acpi.patch
    >
    > Looks like some changes in this patch break sn2. In particular, this hunk in
    > acpi_pci_irq_enable():
    >
    > - if (dev->irq && (dev->irq <= 0xF)) {
    > + if (dev->irq >= 0 && (dev->irq <= 0xF)) {
    > printk(" - using IRQ %d\n", dev->irq);
    > return_VALUE(dev->irq);
    > }
    > else {
    > printk("\n");
    > - return_VALUE(0);
    > + return_VALUE(-EINVAL);
    > }
    >
    > Now instead of returning 0, we'll get -EINVAL when a driver calls
    > pci_enable_device. This is arguably correct since there's no _PRT entry (and
    > in fact no ACPI namespace on sn2), but shouldn't the code above be looking at
    > the 'pin' value instead of dev->irq? The sn2 specific PCI code sets up each
    > dev->irq long before this with the correct values...

    I think the change above is actually from
    incorrect-pci-interrupt-assignment-on-es7000-for-pin-zero.patch

    of which I am officially ignorant :-)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.022 / U:90.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site