lkml.org 
[lkml]   [2004]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-NEW] allow root to modify raw scsi command permissions list
On Wed, 15 Sep 2004 19:36:18 -0400
Peter Jones <pjones@redhat.com> wrote:

> Yes.
>
> Here's another version of the patch. It does what yours did, as well as
> that. It also combines the read and write code so there's one of each,
> with a parameter to tell which it's supposed to modify.

Looks *slightly* better than mine ;-)

But

> +static ssize_t rcf_cmds_store(struct rawio_cmd_filter *rcf, const char *page,
> + size_t count, int rw)
...
> + ss.from = (char *)page+ret;
> + ss.to = (char *)page+ret+1;

needs to be

> + ss.from = (char *)page+ret;
> + ss.to = (char *)page+ret+2;

Regards
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.073 / U:2.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site