Messages in this thread | | | Date | Tue, 14 Sep 2004 09:37:55 -0700 | From | Hanna Linder <> | Subject | Re: [RFT 2.6.9-rc1 alpha sys_sio.c] [2/2] convert pci_find_device to pci_get_device |
| |
--On Tuesday, September 14, 2004 04:21:25 AM +0200 Tonnerre <tonnerre@thundrix.ch> wrote: > On Mon, Sep 13, 2004 at 07:02:22PM -0700, Richard Henderson wrote: >> On Tue, Sep 14, 2004 at 02:29:33AM +0200, Tonnerre wrote: >> > Don't we need to put these devices in some place? >> >> pci_get_device does that for non-null "from" argument. > > I was talking about pci_put_device(dev).. > > Tonnerre
Hi Tonnerre,
I believe that is what Richard is talking about as well. When pci_get_device is in a while loop the dereference is done automatically. See the code and comments.
You will notice in the sys_alcor.c patch I did add the pci_dev_put (although in the wrong place, new patch coming soon).
Regards,
Hanna
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |