Messages in this thread | | | Date | Tue, 14 Sep 2004 11:55:31 -0700 | From | Greg KH <> | Subject | Re: Patch for 3 ub bugs in 2.6.9-rc1-mm4 |
| |
On Sat, Sep 11, 2004 at 08:25:25PM -0700, Pete Zaitcev wrote: > Hi, Greg, > > Actual users of ub quickly found problems, so here's a patch to address > some of them. > > #1: An attempt to mount a CF card, pull the plug, then unmount causes a > message "getblk: bad sector size 512" and an oops. This is caused by > trying to do put_disk from disconnect instead of using a reference count. > The sd.c does it this way (it uses kref). > > #2: The hald fills /var/log/messages with block device errors. It seems > that it happens because ub allowed opens of known offline devices, and > then partition checking produced those errors. I hope taking code from > sd.c should fix it. > > Also I replaced usb_unlink_urb with usb_kill_urb.
Applied, thanks.
(oops, you forgot the Signed-off-by: line...)
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |