lkml.org 
[lkml]   [2004]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2.6.8.1] BSD accounting: update chars transferred value
    On Fri, Sep 10, 2004 at 04:10:56PM -0700, Jay Lan wrote:
    > This patch is a subset of csa_io with your patch deals with character
    > IO only.

    Yes you are right. This patch only deals with character IO because I
    don't know yet how to get information for blocks IO. As I said my goal
    is to provide a good solution for accounting. BSD-accounting is already
    in the kernel and CSA provide more metrics so I think it could be good
    to add some CSA accounting values in the BSD-accounting.

    > I can see that merge csa_io's change at vfs_writev() and vfs_readv()
    > into your change at do_readv_writev(). However, the code change is
    > not really common code in that a) the operation type is different and
    > 2) the fields to add to are different, so you end up doing extra check
    > of file operation type (READ vs WRITE). I would be happy if either
    > your patch or mine is accepted, but i think it does extra work to put
    > the changes into the common routine (ie do_readv_writev).

    As you notice, vfs_writev() and vfs_readv() both call do_readv_writev()
    and as fields to add are different I added a test on the operation type.
    I though that it was interesting to put a changes in the common routine
    but you are right that it has a cost (the file operation check). As the
    changes can be done in vfs_readv() and vfs_writev() instead of one single
    routine (do_readv_writev()) I though this choice was good but if the
    extra cost is a problem I agree with your solution. Thank you to point
    this out.

    > Shall we combine your patch and SGI's csa_io patch?

    IMHO, it could be very interesting to combine your patch and mine.
    BSD-accounting is doing per-process accounting and CSA also doing
    per-process accounting even if the goal is a per-job accounting. Thus, I
    think that it can be good to combine both. It isn't necessary to have
    two different accounting systems in the kernel.

    Is it difficult for you to add what you are doing with CSA in the
    BSD-accounting file? Maybe the solution is to remove BSD-accounting in
    favor of CSA accounting? Personally, I don't care if we keep
    BSD-accounting or if we remove it to add CSA accounting.

    Best,
    Guillaume
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:4.444 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site