lkml.org 
[lkml]   [2004]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: 2.4.28-pre3: broken ips update
From
Date
On Mon, 2004-09-13 at 16:28, Hammer, Jack wrote:
> Marcelo,

> --- linux.orig/drivers/scsi/ips.h Mon Sep 13 09:40:04 2004
> +++ linux/drivers/scsi/ips.h Mon Sep 13 09:40:27 2004
> @@ -97,7 +97,7 @@
>
> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>
> - #ifndef irqreturn_t
> + #if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,23)
> typedef void irqreturn_t;
> #endif
>

your fix is wrong.
you should nuke all version codes, and ONLY ifndef for IRQ_NONE and
nothing else. That's not just cosmetics, that's also to make keep
working with those exact vendor kernels you claim to have tested on :)

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.040 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site