[lkml]   [2004]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Add sparse "__iomem" infrastructure to check PCI address usage

    On Mon, 13 Sep 2004, Geert Uytterhoeven wrote:
    > While resuming adding __user annotations to the m68k-specific parts of the
    > code, I stumbled on
    > struct task_struct {
    > ...
    > unsigned long sas_ss_sp;
    > ...
    > }
    > If I'm not mistaken, sas_ss_sp is always a pointer to user stack space.
    > Shouldn't it be changed to `void __user *sas_ss_sp', or is an
    > unsigned long/void * change in generic code a too controversial change for
    > making sparse happy?

    I don't think it's too controversial per se, and it would certainly remove
    at least two casts from kernel/signal.c. Are you ready to fix up some
    other architectures from the fall-out (x86 at the least..)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-11-18 23:46    [W:0.020 / U:75.516 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site