Messages in this thread Patch in this message | | | Date | Mon, 13 Sep 2004 12:55:18 +0900 | From | Kenji Kaneshige <> | Subject | Re: [PATCH] missing pci_disable_device() |
| |
Here is an updated patch for missing pci_disable_device(). Greg, please apply.
Thanks, Kenji Kaneshige
As mentioned in Documentaion/pci.txt, pci device driver should call pci_disable_device() when it decides to stop using the device. But there are some drivers that don't use pci_disable_device() so far.
This patch adds warning messages that are displayed if the device is removed without properly calling pci_disable_device().
'WARN_ON(1)' is commented out for now because I guess many people (including some distros) enables 'CONFIG_DEBUG_KERNEL'. People might be surprised if many stack dumps are displayed on their console.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
linux-2.6.9-rc1-kanesige/drivers/pci/pci-driver.c | 13 +++++++++++++ 1 files changed, 13 insertions(+)
diff -puN drivers/pci/pci-driver.c~force_pci_disable_device drivers/pci/pci-driver.c --- linux-2.6.9-rc1/drivers/pci/pci-driver.c~force_pci_disable_device 2004-09-13 12:41:23.588330045 +0900 +++ linux-2.6.9-rc1-kanesige/drivers/pci/pci-driver.c 2004-09-13 12:41:23.591259749 +0900 @@ -291,6 +291,19 @@ static int pci_device_remove(struct devi drv->remove(pci_dev); pci_dev->driver = NULL; } + +#ifdef CONFIG_DEBUG_KERNEL + /* + * If the driver decides to stop using the device, it should + * call pci_disable_device(). + */ + if (pci_dev->is_enabled) { + dev_warn(&pci_dev->dev, "Device was removed without properly " + "calling pci_disable_device(). This may need fixing.\n"); + /* WARN_ON(1); */ + } +#endif /* CONFIG_DEBUG_KERNEL */ + pci_dev_put(pci_dev); return 0; } _
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |