lkml.org 
[lkml]   [2004]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed
    Greg KH wrote:
    > On Thu, Sep 09, 2004 at 03:24:54PM -0700, Andrew Morton wrote:
    >
    >>Eric Valette <eric.valette@free.fr> wrote:
    >>
    >>>Here is a small patch that makes the card functionnal again. I've
    >>>forwarded the patch to driver author also.
    >>>
    >>>--- linux/drivers/usb/net/rtl8150.c-2.6.9-rc1-mm4.orig 2004-09-09 11:15:11.000000000 +0200
    >>>+++ linux/drivers/usb/net/rtl8150.c 2004-09-09 11:15:46.000000000 +0200
    >>>@@ -341,7 +341,7 @@
    >>>
    >>> static int rtl8150_reset(rtl8150_t * dev)
    >>> {
    >>>- u8 data = 0x11;
    >>>+ u8 data = 0x10;
    >>
    >>hm, OK. Presumably the change (which comes in via the bk-usb tree) was
    >>made for a reason. So I suspect both versions are wrong ;)
    >>
    >>But it might be risky for Greg to merge this patch up at present.
    >
    >
    > As all your patch does is revert the patch in my tree (it was a one line
    > change), mainline should work just fine for you, right?
    >
    > I'll defer to Petkan as to what to do about this, as he sent me that
    > patch for a good reason I imagine :)

    FYI : I already forwarded the patch to the author. Just copied LKML so
    that other can get the fix easily.

    NB : I just reverted one small change, the rest of the changes (mainly
    access to driver private data, and IOCTL ops) are OK...

    --
    __
    / ` Eric Valette
    /-- __ o _. 6 rue Paul Le Flem
    (___, / (_(_(__ 35740 Pace

    Tel: +33 (0)2 99 85 26 76 Fax: +33 (0)2 99 85 26 76
    E-mail: eric.valette@free.fr



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:0.023 / U:0.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site