Messages in this thread Patch in this message | | | Date | Fri, 10 Sep 2004 11:46:58 +0100 | From | viro@parcelfa ... | Subject | Re: [PATCH] Fix DHCP ipconfig.c |
| |
On Fri, Sep 10, 2004 at 10:45:15AM +0100, Russell King wrote: > bk-curr seems to be a little sick here: > > CC net/ipv4/ipconfig.o > net/ipv4/ipconfig.c: In function `ic_bootp_recv': > net/ipv4/ipconfig.c:969: error: `i' undeclared (first use in this function) > net/ipv4/ipconfig.c:969: error: (Each undeclared identifier is reported only once > net/ipv4/ipconfig.c:969: error: for each function it appears in.) > > and here's the medicine:
And here's better one:
diff -urN RC9-rc1-bk16-base/net/ipv4/ipconfig.c RC9-rc1-bk16-current/net/ipv4/ipconfig.c --- RC9-rc1-bk16-base/net/ipv4/ipconfig.c 2004-09-10 02:13:24.000000000 -0400 +++ RC9-rc1-bk16-current/net/ipv4/ipconfig.c 2004-09-10 03:40:10.000000000 -0400 @@ -966,9 +966,7 @@ break; case DHCPACK: - for (i = 0; (dev->dev_addr[i] == b->hw_addr[i]) - && (i < dev->addr_len); i++); - if (i < dev->addr_len) + if (memcmp(b->hw_addr, dev->dev_addr, dev->addr_len) != 0) goto drop_unlock; /* Yeah! */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |