lkml.org 
[lkml]   [2004]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[patch 05/14] radio/radio-cadet: replace schedule_timeout() with msleep()
    From
    Date






    I would appreciate any comments from the janitor@sternweltens list.

    Thanks,
    Nish



    Description: Uses msleep() instead of schedule_timeout() so the task
    is guaranteed to delay the desired time.

    Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
    Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



    ---

    linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-cadet.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff -puN drivers/media/radio/radio-cadet.c~msleep-drivers_media_radio-cadet drivers/media/radio/radio-cadet.c
    --- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-cadet.c~msleep-drivers_media_radio-cadet 2004-09-01 19:35:11.000000000 +0200
    +++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-cadet.c 2004-09-01 19:35:11.000000000 +0200
    @@ -69,8 +69,7 @@ static int cadet_getrds(void)
    outb(inb(io+1)&0x7f,io+1); /* Reset RDS detection */
    spin_unlock(&cadet_io_lock);

    - set_current_state(TASK_UNINTERRUPTIBLE);
    - schedule_timeout(HZ/10);
    + msleep(100);

    spin_lock(&cadet_io_lock);
    outb(3,io); /* Select Decoder Control/Status */
    @@ -243,8 +242,7 @@ static void cadet_setfreq(unsigned freq)
    outb(curvol,io+1);
    spin_unlock(&cadet_io_lock);

    - set_current_state(TASK_UNINTERRUPTIBLE);
    - schedule_timeout(HZ/10);
    + msleep(100);

    cadet_gettune();
    if((tunestat & 0x40) == 0) { /* Tuned */
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:05    [W:0.022 / U:31.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site