Messages in this thread Patch in this message | | | Date | Wed, 1 Sep 2004 10:27:10 -0700 | From | William Lee Irwin III <> | Subject | [1/7] make do_each_task_pid()/while_each_task_pid() typecheck |
| |
On Wed, Sep 01, 2004 at 08:36:24AM -0700, William Lee Irwin III wrote: >> Could you not rename struct pid and not rename for_each_task_pid()?
On Wed, Sep 01, 2004 at 09:58:08AM -0700, William Lee Irwin III wrote: > On closer examination for_each_task_pid() appears to need > do { ... } while () -like semantics in your scheme, which is nasty > as it allows a ne class of mismatching argument errors, but I suppose > merits the renaming.
list_empty(&task->pids[type].hash_list) does not successfully typecheck; while this does not correct its semantics, it at least restores typechecking long enough for the code to be examined.
Index: kirill-2.6.9-rc1-mm2/include/linux/pid.h =================================================================== --- kirill-2.6.9-rc1-mm2.orig/include/linux/pid.h 2004-09-01 08:44:05.770684392 -0700 +++ kirill-2.6.9-rc1-mm2/include/linux/pid.h 2004-09-01 08:49:14.584737520 -0700 @@ -49,7 +49,7 @@ task = pid_task(task->pids[type].pid_list.next, \ type); \ prefetch(task->pids[type].pid_list.next); \ - } while (list_empty(&task->pids[type].hash_list)); \ + } while (task->pids[type].hash_list.next); \ } #endif /* _LINUX_PID_H */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |